Open
Conversation
This reverts commit d5e95c0.
jackkordas
requested review from
aaschaer,
kurtmckee and
sirosen
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jackkordas
force-pushed
the
jack/async
branch
3 times, most recently
from
f6e1df0 to
93ebf85
Compare
pjhinton-globus
approved these changes
Aug 22, 2025
Collaborator
pjhinton-globus
left a comment
pjhinton-globus
left a comment
There was a problem hiding this comment.
Just found a couple of places where checks on type are probably not needed. Will leave to author's discretion on whether to remove them.
pjhinton-globus
approved these changes
Aug 28, 2025
added 2 commits
September 16, 2025 14:39
uvloop is used by UvicornWorker for perfomance MagicStack/uvloop#528
jackkordas
force-pushed
the
jack/async
branch
from
f147798 to
74cccff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transfer needs an async interface. Transfer is using UvicornWorker. UvicornWorker uses uvloop for performance. uvloop has a bug with abstract unix sockets so part of this is changing the client and daemon to use a non-virtual unix socket.